Codecov Report

Attention: Patch coverage is 17.77778% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 45.04%. Comparing base (5da2c9e) to head (8733918).

@@             Coverage Diff             @@
##           develop      #54      +/-   ##
===========================================
- Coverage    45.19%   45.04%   -0.16%     
===========================================
  Files           42       42              
  Lines         4290     4318      +28     
  Branches       876      885       +9     
===========================================
+ Hits          1939     1945       +6     
- Misses        2173     2193      +20     
- Partials       178      180       +2     

@gpetretto I had a go at fixing some of the typing issues suggested by mypy but I'm not entirely convinced by a lot of the annotations I am adding. Would you be able to take a look? (probably before merging this?)

Sure. Do you want me to try to apply this change locally and check the typing issues? Or do you already have a list of problematic ones to be verified?

Sure. Do you want me to try to apply this change locally and check the typing issues? Or do you already have a list of problematic ones to be verified?

I'll push the changes I'm happy with to this PR and try to point out the ones that are weird

Sure. Do you want me to try to apply this change locally and check the typing issues? Or do you already have a list of problematic ones to be verified?

I'll push the changes I'm happy with to this PR and try to point out the ones that are weird

I've just pushed these, the remaining lint errors are the weird ones (mostly lots of awkward typing around the db potentially returning None) -- hopefully the enum value changes are fine though

I checked some of the errors related to the None and, while they are not real errors as the check on the object not being None is performed somewhere else, mypy is likely not able to deduce that. Not sure what is the best strategy here: either skip the check or adding some redundant check on the object not being None. I can do that, so I will also check that they are all indeed correct.

The other errors could probably be resolved by adding __all__ to the __init__.py files that have imports.

I am not sure about replacing the values of the Enums with the Enums instance in the CLI. Does it work? Should I test it?

I've finally got around to fixing the mypy issues in b7b7f81, mostly by just adding checks for None where appropriate. Could you take another look @gpetretto?

Annoyingly this is now back in the state where the tests work locally but not in the CI; I'll try to debug it when I get a chance but for now do not let this PR hold up the other ones that actually add features.

Annoyingly this is now back in the state where the tests work locally but not in the CI; I'll try to debug it when I get a chance but for now do not let this PR hold up the other ones that actually add features.

After your last commit it seems that only a lint issue remains in the tests. Depending on your availability, I suppose these can be fixed and then we can merge this before the other PRs.

After your last commit it seems that only a lint issue remains in the tests. Depending on your availability, I suppose these can be fixed and then we can merge this before the other PRs.

Think that's got it -- I won't be able to take a look at the other PRs again until Friday so feel free to do with this as you please!